Fix shader compilation fail when using visibility range #21879
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoZweifel
reviewed
Nov 18, 2025
Contributor
NicoZweifel
left a comment
NicoZweifel
left a comment
There was a problem hiding this comment.
I was able to reproduce the issue in both examples and the PR fixes both examples.
One import at the top instead of in both blocks (#ifdef and #else) would be nice though.
NicoZweifel
approved these changes
Nov 18, 2025
Contributor
NicoZweifel
left a comment
NicoZweifel
left a comment
There was a problem hiding this comment.
I accidentally left some empty lines in the suggestions but looks good to go to me, thanks!
NicoZweifel
reviewed
Nov 18, 2025
Co-authored-by: Nico Zweifel <[email protected]>
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Nov 18, 2025
alice-i-cecile
added
the
S-Ready-For-Final-Review
dloukadakis
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When using both deferred rendering and visibility range, shader
pbr.wgslcan't be compiled becausepbr_functionsis not imported.The issue can be reproduced by using
DefaultOpaqueRendererMethod::deferred()and addingDeferredPrepassto camera at the visibility_range example.Solution
Import
pbr_functionswhen usingPREPASS_PIPELINE.Testing
I tested on visibility_range and deferred_rendering example. However, importing something usually doesn't break anything.